Removed obsolete solution filters #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescrosswell
changed the title
bitsandfoxes
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
Overview
We don't need all of the solution filteres that we have defined for CI.
Sentry-CI-Test.slnf- We can also use the same solution filter fordotnet testthat we use fordotnet buildSentry-CI-Pack.slnf- We can also use the same solution filter we use fordotnet buildin conjunction with the<IsPackable>false</IsPackable>build prop (which can be set inDirectory.Build.props)Sentry-CI-CodeQL.slnfis a little bit tricker, as this should exclude**/Sentry.Bindings*.csproj... but we really need that to build/test... so for the time being, we might have to keep this additional filter. Since it's now automatically generated, it shouldn't be a big burden to maintain though.