Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for feedback envelope header item type #3687

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Sep 11, 2024

📜 Description

Adds the feedback envelope header item type

💡 Motivation and Context

Feedback envelope items are just regular envelope items, with additional context data and support for attachments.

Currently we are implementing this on flutter, and android is the only platform missing, as the type is lost from the envelope sent to the native sdk from the flutter side.

Relates to getsentry/sentry-dart#2230 (comment)

💚 How did you test it?

Added unit tests.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

Copy link
Contributor

github-actions bot commented Sep 11, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 598b002

@denrase denrase marked this pull request as ready for review September 11, 2024 10:04
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 419.06 ms 454.98 ms 35.92 ms
Size 1.70 MiB 2.35 MiB 661.04 KiB

Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@denrase denrase enabled auto-merge (squash) September 17, 2024 09:29
@denrase denrase merged commit 61c8d80 into main Sep 17, 2024
24 of 25 checks passed
@denrase denrase deleted the feat/support-feedback-sentry-item-type branch September 17, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants