Skip to content

Commit

Permalink
Reference LOGAF Scale from develop docs
Browse files Browse the repository at this point in the history
Link to the Sentry develop docs for explaining the LOGAF scale.
  • Loading branch information
philipphofmann authored Jan 24, 2025
1 parent 2e708dc commit dc6c3a8
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions docs/pr-reviews.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,8 @@

Make sure to open PRs against `develop` branch.

For feedback in PRs, we use the [LOGAF scale](https://blog.danlew.net/2020/04/15/the-logaf-scale/) to specify how
important a comment is:

- `l`: low - nitpick. You may address this comment, but you don't have to.
- `m`: medium - normal comment. Worth addressing and fixing.
- `h`: high - Very important. We must not merge this PR without addressing this issue.
For feedback in PRs, we use the [LOGAF scale](https://develop.sentry.dev/engineering-practices/code-review/#logaf-scale) to specify how
important a comment is.

You only need one approval from a maintainer to be able to merge. For some PRs, asking specific or multiple people for
review might be adequate. You can either assign SDK team members directly (e.g. if you have some people in mind who are
Expand Down

0 comments on commit dc6c3a8

Please sign in to comment.