Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Make "Required Tests passed" job depend on artifact upload and other required jobs #8751

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Aug 8, 2023

This PR adjusts our final "Required Tests Passed" CI job to not only depend on required test jobs but on all required jobs. Specifically, this adds

  • Lint
  • Circular deps check
  • Most importantly: Upload Artifacts

With this change, we can configure craft's status provider to specifically wait for this job which should fix the artifacts download timeout (getsentry/craft#482). It's worth noting that this PR will only fix this timeout in our repo and in a way we're adjusting to the status provider check. However, given that we're apparently the only repo where this happens, it's probably justified and it makes things more explicit.

This will also allow us to unmark Lint and Circular Deps Check as required in the GH UI as we're now relying on the job for it.

@Lms24 Lms24 requested a review from mydea August 8, 2023 09:38
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 74.96 KB (+0.14% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.11 KB (0%)
@sentry/browser - Webpack (gzipped) 21.81 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.58 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.15 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.17 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 219.29 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 84.67 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 59.83 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.02 KB (+0.01% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 65.16 KB (+0.16% 🔺)
@sentry/react - Webpack (gzipped) 21.84 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 92.78 KB (+0.15% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.64 KB (+0.06% 🔺)

@mydea
Copy link
Member

mydea commented Aug 8, 2023

We need to sync merging this with @stephanie-anderson updating the github settings to require the new job in GH!

@Lms24 Lms24 force-pushed the lms/ref-required-jobs-passed branch 2 times, most recently from 3d98565 to 17ee6c6 Compare August 8, 2023 12:56
@Lms24 Lms24 force-pushed the lms/ref-required-jobs-passed branch from 17ee6c6 to 50d6867 Compare August 8, 2023 13:29
@Lms24 Lms24 closed this Aug 8, 2023
@Lms24 Lms24 reopened this Aug 8, 2023
@Lms24 Lms24 merged commit 672e56c into develop Aug 8, 2023
91 of 168 checks passed
@Lms24 Lms24 deleted the lms/ref-required-jobs-passed branch August 8, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants