chore(ci): Make "Required Tests passed" job depend on artifact upload and other required jobs #8751
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts our final "Required Tests Passed" CI job to not only depend on required test jobs but on all required jobs. Specifically, this adds
With this change, we can configure craft's status provider to specifically wait for this job which should fix the artifacts download timeout (getsentry/craft#482). It's worth noting that this PR will only fix this timeout in our repo and in a way we're adjusting to the status provider check. However, given that we're apparently the only repo where this happens, it's probably justified and it makes things more explicit.
This will also allow us to unmark Lint and Circular Deps Check as required in the GH UI as we're now relying on the job for it.