-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Add http timeouts even if no http_proxy is used #1034
Conversation
ERROR: UndefinedClass - src/HttpClient/HttpClientFactory.php:117:21 UndefinedClass - src/HttpClient/HttpClientFactory.php:118:21
I don't know how to suppress the UndefinedClass error in psalm, maybe someone can help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, apart from the static analysis failures.
IMHO we should use stubs or install the optional dependencies while running those; I would prefer the second, since it would always work, in local too.
Just move the annotation before the declaration of the
We could install those dependencies as part of |
ERROR: UndefinedClass - src/HttpClient/HttpClientFactory.php:118:21 - Class or interface GuzzleHttp\RequestOptions does not exist (see https://psalm.dev/019) ERROR: UndefinedClass - src/HttpClient/HttpClientFactory.php:120:21 - Class or interface GuzzleHttp\RequestOptions does not exist (see https://psalm.dev/019)
Thanks! How can I help to get the patch into the next release? |
Would you mind adding also an entry to the CHANGELOG? I always forget about asking this 🤦
As soon as we merge it it will be already part of the next patch release which I would like to release shortly after |
Fixes #1033