-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Hub from our test suite #3197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* build(deps): bump actions/checkout from 4.1.6 to 4.1.7 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.6 to 4.1.7. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.1.6...v4.1.7) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * also update in templates --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ivana Kellyerova <[email protected]>
…#3193) * build(deps): bump supercharge/redis-github-action from 1.7.0 to 1.8.0 Bumps [supercharge/redis-github-action](https://github.com/supercharge/redis-github-action) from 1.7.0 to 1.8.0. - [Release notes](https://github.com/supercharge/redis-github-action/releases) - [Changelog](https://github.com/supercharge/redis-github-action/blob/main/CHANGELOG.md) - [Commits](supercharge/redis-github-action@1.7.0...1.8.0) --- updated-dependencies: - dependency-name: supercharge/redis-github-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * update in template too --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ivana Kellyerova <[email protected]>
Changed the calling position of the `spark_context_init` func to ensure that SparkIntegration is used prior to the creation of the Spark session. --------- Co-authored-by: shaun.glass <[email protected]>
antonpirker
force-pushed
the
antonpirker/remove-hub-from-tests
branch
from
June 25, 2024 12:20
b9fdbb0
to
b2f0f67
Compare
Aand removed test that was already skipped because it tests Celery 3 behavior which we do not support anymore.
Adds `types-webob`, `types-greenlet` and `types-gevent` to linter requirements and fixes newly exposed typing issues.
antonpirker
force-pushed
the
antonpirker/remove-hub-from-tests
branch
from
June 25, 2024 12:23
1af2d39
to
f5dd9ce
Compare
sentrivana
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great ✨
Remove Hub usage in integrations.
arjennienhuis
pushed a commit
to arjennienhuis/sentry-python
that referenced
this pull request
Sep 30, 2024
Remove Hub usage from our test suite. We keep the tests that test the hubs/scopes-refactoring until we actually remove the Hub from the public API. Also removing Hub usage from some of our integrations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Hub usage from our test suite. We keep the tests that test the hubs/scopes-refactoring until we actually remove the Hub from the public API.
During removing the hub from the tests, I discovered that some integrations still use the hub, I removed it in this PR:
#3201
Fixes #3154