Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hub from our test suite #3197

Merged
merged 24 commits into from
Jun 25, 2024
Merged

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Jun 25, 2024

Remove Hub usage from our test suite. We keep the tests that test the hubs/scopes-refactoring until we actually remove the Hub from the public API.

During removing the hub from the tests, I discovered that some integrations still use the hub, I removed it in this PR:
#3201

Fixes #3154

antonpirker and others added 14 commits June 25, 2024 14:20
* build(deps): bump actions/checkout from 4.1.6 to 4.1.7

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.6 to 4.1.7.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4.1.6...v4.1.7)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* also update in templates

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ivana Kellyerova <[email protected]>
…#3193)

* build(deps): bump supercharge/redis-github-action from 1.7.0 to 1.8.0

Bumps [supercharge/redis-github-action](https://github.com/supercharge/redis-github-action) from 1.7.0 to 1.8.0.
- [Release notes](https://github.com/supercharge/redis-github-action/releases)
- [Changelog](https://github.com/supercharge/redis-github-action/blob/main/CHANGELOG.md)
- [Commits](supercharge/redis-github-action@1.7.0...1.8.0)

---
updated-dependencies:
- dependency-name: supercharge/redis-github-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* update in template too

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ivana Kellyerova <[email protected]>
Changed the calling position of the `spark_context_init` func to ensure
that SparkIntegration is used prior to the creation of the Spark session.

---------

Co-authored-by: shaun.glass <[email protected]>
@antonpirker antonpirker force-pushed the antonpirker/remove-hub-from-tests branch from b9fdbb0 to b2f0f67 Compare June 25, 2024 12:20
antonpirker and others added 6 commits June 25, 2024 14:23
Aand removed test that was already skipped because it tests Celery 3 behavior which we do not support anymore.
Adds `types-webob`, `types-greenlet` and `types-gevent` to linter
requirements and fixes newly exposed typing issues.
@antonpirker antonpirker force-pushed the antonpirker/remove-hub-from-tests branch from 1af2d39 to f5dd9ce Compare June 25, 2024 12:23
@antonpirker antonpirker self-assigned this Jun 25, 2024
@antonpirker antonpirker marked this pull request as ready for review June 25, 2024 15:00
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great ✨

@antonpirker antonpirker enabled auto-merge (squash) June 25, 2024 15:23
@antonpirker antonpirker merged commit ac5c8e8 into master Jun 25, 2024
120 checks passed
@antonpirker antonpirker deleted the antonpirker/remove-hub-from-tests branch June 25, 2024 15:32
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
Remove Hub usage from our test suite. We keep the tests that test the hubs/scopes-refactoring until we actually remove the Hub from the public API. Also removing Hub usage from some of our integrations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove uses of Hub from tests
4 participants