-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LaunchDarkly and OpenFeature integration #3648
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3648 +/- ##
==========================================
+ Coverage 84.29% 84.33% +0.04%
==========================================
Files 133 136 +3
Lines 14262 14367 +105
Branches 2405 2417 +12
==========================================
+ Hits 12022 12117 +95
- Misses 1489 1497 +8
- Partials 751 753 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will have a proper look soon -- just two comments regarding tox for now
Co-authored-by: Ivana Kellyer <[email protected]>
Co-authored-by: Ivana Kellyer <[email protected]>
Hey @cmanallen ! This is the best PR I have received ever! Great work. The integrations should not change the Scope. I have created an commit on your branch to illustrate how the flags could live on the integration rather than the scope (I hope you don't mind): This way all the functionality is contained in the integration. wdyt? Feel free to make changes to my commit if you want to do things differently. |
This reverts commit 430387f.
@antonpirker Reverted your commit per our conversation on Slack. Tl;dr the commit didn't work because we need to be tied to the scope to maintain flag isolation. After @sl0thentr0py's comment about it being fine to keep the flags on the scope if this change is permanent I think its appropriate to revert that change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussion with the team updating the scope is fine. This is ready to be merged!
Thanks @antonpirker and welcome back! |
Adds LaunchDarkly and OpenFeature integration and extends the
Scope
with aflags
property.As flags are evaluated by an application they are stored within the Sentry SDK (lru cache). When an error occurs we fetch the flags stored in the SDK and serialize them on the event.