Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix starlette tests #3749

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fix starlette tests #3749

merged 1 commit into from
Nov 11, 2024

Conversation

sl0thentr0py
Copy link
Member

mainly some middleware span reordering

@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

❌ 4786 Tests Failed:

Tests completed Failed Passed Skipped
20880 4786 16094 4477
View the top 2 failed tests by shortest run time 
tests.integrations.django.test_basic test_rest_framework_basic[application/json-1-rest_framework_read_body_and_exc]
Stack Traces | 0s run time 
No failure message available

tests.integrations.django.test_basic test_template_exception[with_executing_integration1]
Stack Traces | 0s run time 
No failure message available
View the full list of 1 ❄️ flaky tests 
tests.integrations.django.test_basic test_middleware_exceptions

Flake rate in main: 55.56% (Passed 8 times, Failed 10 times)

Stack Traces | 0s run time 
No failure message available

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

antonpirker
antonpirker approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tests/integrations/starlette/test_starlette.py Outdated Show resolved Hide resolved
Base automatically changed from neel/potel/only-if-parent to potel-base November 11, 2024 09:39
@sl0thentr0py sl0thentr0py force-pushed the neel/potel/fix-starlette branch 2 times, most recently from 8444e11 to 3e4dbf6 Compare November 11, 2024 15:26
@sl0thentr0py
Fix most starlette tests
e056358 
mainly some middleware span reordering
@sl0thentr0py sl0thentr0py merged commit fbbf5e7 into potel-base Nov 11, 2024
3 of 5 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/potel/fix-starlette branch November 11, 2024 15:27
@sl0thentr0py sl0thentr0py mentioned this pull request Nov 11, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker approved these changes

@sentrivana sentrivana Awaiting requested review from sentrivana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sl0thentr0py @antonpirker