Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use semantic attributes in traces sampler for ASGI spans #3774

Merged

Conversation

sentrivana
Copy link
Contributor

Instead of just naming the new span attrs asgi_scope.{property}, use OTel's semantic attributes where appropriate

Copy link

codecov bot commented Nov 14, 2024

❌ 1613 Tests Failed:

Tests completed Failed Passed Skipped
19831 1613 18218 4413
View the top 1 failed tests by shortest run time
tests.test_utils test_datetime_from_isoformat[2021-01-01T00:00:00.000000-00:00-expected_output4]
Stack Traces | 0.001s run time
tests/test_utils.py:109: in test_datetime_from_isoformat
    assert datetime_from_isoformat(input_str) == expected_output, input_str
E   NameError: name 'datetime_from_isoformat' is not defined
View the full list of 2 ❄️ flaky tests
tests.test_utils test_datetime_from_isoformat[2021-01-01T00:00:00.000000-0000-expected_output6]

Flake rate in main: 54.93% (Passed 32 times, Failed 39 times)

Stack Traces | 0.001s run time
tests/test_utils.py:109: in test_datetime_from_isoformat
    assert datetime_from_isoformat(input_str) == expected_output, input_str
E   NameError: name 'datetime_from_isoformat' is not defined
tests.test_scope test_with_isolation_scope_data

Flake rate in main: 99.13% (Passed 2 times, Failed 227 times)

Stack Traces | 0.001s run time
tests/test_scope.py:387: in test_with_isolation_scope_data
    assert scope._tags == {"before_isolation_scope": 1}
E   AssertionError: assert {} == {'before_isolation_scope': 1}
E     
E     Right contains 1 more item:
E     {'before_isolation_scope': 1}
E     
E     Full diff:
E     + {}
E     - {
E     -     'before_isolation_scope': 1,
E     - }

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@@ -246,7 +246,6 @@ async def _error(request: Request):
assert event["request"]["headers"]["authorization"] == "[Filtered]"


@pytest.mark.asyncio
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytest was complaining that these 3 test cases shouldn't have @pytest.mark.asyncio

@sentrivana sentrivana marked this pull request as ready for review November 14, 2024 11:30
@sentrivana sentrivana merged commit 6c6ac09 into potel-base Nov 14, 2024
32 of 122 checks passed
@sentrivana sentrivana deleted the ivana/custom-sampling-context-integrations-extra-stuff branch November 14, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants