-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use semantic attributes in traces sampler for ASGI spans #3774
Use semantic attributes in traces sampler for ASGI spans #3774
Conversation
❌ 1613 Tests Failed:
View the top 1 failed tests by shortest run time
View the full list of 2 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
@@ -246,7 +246,6 @@ async def _error(request: Request): | |||
assert event["request"]["headers"]["authorization"] == "[Filtered]" | |||
|
|||
|
|||
@pytest.mark.asyncio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytest was complaining that these 3 test cases shouldn't have @pytest.mark.asyncio
Instead of just naming the new span attrs
asgi_scope.{property}
, use OTel's semantic attributes where appropriate