fix: include_tracing_fields arg to control unvetted data in rust_tracing integration #3780
+59
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented my suggestion from #3778 so that if anton agrees we can merge this before the weekend
this PR renames the
send_sensitive_data
flag toinclude_tracing_fields
. the data in question is generally data the user expectstracing
to record or data they explicitly passed into a log statement to be recorded, so if we call it "sensitive" they may think we are referring to something elsealso, this PR applies the same condition to both
on_record()
andon_new_span()
. both callbacks set the same fields, so they should either both be redacted or both be allowed. previously onlyon_record()
had the condition applied.Thank you for contributing to
sentry-python
! Please add tests to validate your changes, and lint your code usingtox -e linters
.Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.