Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract span attrs from RQ job object #3786

Draft
wants to merge 1 commit into
base: potel-base
Choose a base branch
from

Conversation

sentrivana
Copy link
Contributor

WIP

  • replace rq_job with some meaningful span attrs to populate the sampling context in traces sampler

Note to self: looks like there are no real semconvs for task queues in OTel. Look at what the OTel Celery integration is setting and try to replicate that

@sentrivana sentrivana mentioned this pull request Nov 15, 2024
12 tasks
Copy link

codecov bot commented Nov 15, 2024

❌ 1710 Tests Failed:

Tests completed Failed Passed Skipped
20003 1710 18293 4413
View the top 1 failed tests by shortest run time
tests.test_utils test_datetime_from_isoformat[2021-01-01T00:00:00.000000-00:00-expected_output4]
Stack Traces | 0.001s run time
tests/test_utils.py:109: in test_datetime_from_isoformat
    assert datetime_from_isoformat(input_str) == expected_output, input_str
E   NameError: name 'datetime_from_isoformat' is not defined
View the full list of 2 ❄️ flaky tests
tests.test_utils test_datetime_from_isoformat[2021-01-01T00:00:00.000000-0000-expected_output6]

Flake rate in main: 58.06% (Passed 39 times, Failed 54 times)

Stack Traces | 0.001s run time
tests/test_utils.py:109: in test_datetime_from_isoformat
    assert datetime_from_isoformat(input_str) == expected_output, input_str
E   NameError: name 'datetime_from_isoformat' is not defined
tests.test_scope test_with_isolation_scope_data

Flake rate in main: 99.16% (Passed 2 times, Failed 237 times)

Stack Traces | 0.001s run time
tests/test_scope.py:387: in test_with_isolation_scope_data
    assert scope._tags == {"before_isolation_scope": 1}
E   AssertionError: assert {} == {'before_isolation_scope': 1}
E     
E     Right contains 1 more item:
E     {'before_isolation_scope': 1}
E     
E     Full diff:
E     + {}
E     - {
E     -     'before_isolation_scope': 1,
E     - }

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant