Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arq tests in POTel #3875

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Fix arq tests in POTel #3875

merged 6 commits into from
Dec 18, 2024

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Dec 17, 2024 •
edited
Loading

Make sure OK status is set, only when there has not been a error status set before.

@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

❌ 296 Tests Failed:

Tests completed Failed Passed Skipped
13112 296 12816 3324
View the top 3 failed tests by shortest run time 
 tests.integrations.celery.integration_tests.test_celery_beat_cron_monitoring
Stack Traces | 0s run time 
No failure message available
 tests.integrations.celery.test_celery_beat_crons
Stack Traces | 0s run time 
No failure message available
 tests.integrations.quart.test_quart
Stack Traces | 0s run time 
No failure message available

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

sentrivana
sentrivana reviewed Dec 17, 2024
View reviewed changes
sentry_sdk/tracing.py Outdated Show resolved Hide resolved
sentrivana
sentrivana approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, see one last comment

sentry_sdk/tracing.py Outdated Show resolved Hide resolved
@antonpirker antonpirker merged commit 60d6333 into potel-base Dec 18, 2024
82 of 111 checks passed
@antonpirker antonpirker deleted the antonpirker/potel/arq branch December 18, 2024 08:30
@antonpirker antonpirker mentioned this pull request Dec 18, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
Project: POTel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonpirker @sentrivana