Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OTEL instrumenter to work even with no DSN. #3898

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow OTEL instrumenter to work even with no DSN. #3898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions sentry_sdk/integrations/opentelemetry/span_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,14 +113,6 @@ def on_start(self, otel_span, parent_context=None):
# type: (OTelSpan, Optional[context_api.Context]) -> None
client = get_client()

if not client.dsn:
return

try:
_ = Dsn(client.dsn)
except Exception:
return

if client.options["instrumenter"] != INSTRUMENTER.OTEL:
return

Expand Down
13 changes: 11 additions & 2 deletions tests/integrations/opentelemetry/test_span_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,16 @@ def test_update_span_with_otel_data_db_query():
)


def test_on_start_transaction():
@pytest.mark.parametrize(
["dsn"],
[
pytest.param(
"https://[email protected]/123456", id="with a DSN"
),
pytest.param(None, id="with no DSN"),
],
)
def test_on_start_transaction(dsn):
otel_span = MagicMock()
otel_span.name = "Sample OTel Span"
otel_span.start_time = time.time_ns()
Expand All @@ -306,7 +315,7 @@ def test_on_start_transaction():

fake_client = MagicMock()
fake_client.options = {"instrumenter": "otel"}
fake_client.dsn = "https://[email protected]/123456"
fake_client.dsn = dsn
sentry_sdk.get_global_scope().set_client(fake_client)

with mock.patch(
Expand Down
Loading