feat(flags): remove Unleash get_variant patching code #3914
+9
−199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3888
Fixing logic error:
After rereading https://docs.getunleash.io/reference/strategy-variants and testing w/ a local Unleash instance, I found we need to use a different variant field,
feature_enabled
.enabled
refers to whether the variant itself is enabled, but a feature/"toggle" can be enabled with no variants. In this case, a disabled variant is returned (seeno_variant_payload
in tests).Update:
The original PR patched 2 methods used for evaluating feature flags,
is_enabled
(simple toggle on/off) andget_variant
(returns a dict of metadata, see https://docs.getunleash.io/reference/sdks/python#getting-a-variant).We want to remove all
get_variant
code since we only support boolean flag evals atm. It seems like Unleash's main usecase for variants is reading payloads (non-bool) for A/B/multivariate testing. This could lead to a lot of extraneous flags, so until it is requested and/or we support non-bool values, let's not patch this method.