Fix build errors due to missing includes (#606)

getsentry · Aug 1, 2024 · b91d6f1 · b91d6f1
1 parent 87291b8
commit b91d6f1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Fixes
+
+- Missing includes errors should no longer pass over CI checks ([#606](https://github.com/getsentry/sentry-unreal/pull/606))
+
 ### Dependencies
 
 - Bump Java SDK (Android) from v7.12.1 to v7.13.0 ([#607](https://github.com/getsentry/sentry-unreal/pull/607))

diff --git a/plugin-dev/Source/SentryEditor/Private/SentrySettingsCustomization.cpp b/plugin-dev/Source/SentryEditor/Private/SentrySettingsCustomization.cpp
@@ -16,6 +16,8 @@
 #include "Misc/ConfigCacheIni.h"
 #include "PropertyHandle.h"
 #include "Framework/Notifications/NotificationManager.h"
+#include "HAL/FileManager.h"
+#include "HAL/PlatformFileManager.h"
 #include "Interfaces/IPluginManager.h"
 #include "Runtime/Launch/Resources/Version.h"
 

diff --git a/sample/Source/SentryPlaygroundEditor.Target.cs b/sample/Source/SentryPlaygroundEditor.Target.cs
@@ -10,6 +10,10 @@ public SentryPlaygroundEditorTarget( TargetInfo Target) : base(Target)
 		Type = TargetType.Editor;
 		DefaultBuildSettings = BuildSettingsVersion.Latest;
 
+		// Disable Unity build and PCH files to catch missing include errors in CI
+		bUseUnityBuild = false;
+		bUsePCHFiles = false;
+
 #if UE_5_1_OR_LATER
 		IncludeOrderVersion = EngineIncludeOrderVersion.Latest;
 #endif