Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Record latency for the billing metrics consumer #60910

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

lynnagara
Copy link
Member

Since getsentry/arroyo#308 Arroyo's CommitOffsets strategy records consumer latency automatically for consumers immediately prior to committing offsets.

Since getsentry/arroyo#308 Arroyo's CommitOffsets strategy
records consumer latency automatically for consumers immediately prior
to committing offsets.
@lynnagara lynnagara requested review from a team November 30, 2023 20:12
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 30, 2023
@lynnagara lynnagara requested a review from vbro November 30, 2023 20:32
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #60910 (78d742b) into master (426a48b) will increase coverage by 1.09%.
Report is 22 commits behind head on master.
The diff coverage is 75.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #60910      +/-   ##
==========================================
+ Coverage   79.86%   80.95%   +1.09%     
==========================================
  Files        5181     5182       +1     
  Lines      226970   227006      +36     
  Branches    38140    38148       +8     
==========================================
+ Hits       181270   183777    +2507     
+ Misses      39984    37615    -2369     
+ Partials     5716     5614     -102     
Files Coverage Δ
src/sentry/ingest/billing_metrics_consumer.py 91.30% <75.00%> (-1.35%) ⬇️

... and 252 files with indirect coverage changes

@lynnagara lynnagara merged commit a3157ca into master Dec 1, 2023
49 of 50 checks passed
@lynnagara lynnagara deleted the billing-metrics-consumer-record-latency branch December 1, 2023 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants