Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(dashboards): Replace Project Details score cards with BigNumberWidget #78566

Merged

Conversation

gggritso
Copy link
Member

@gggritso gggritso commented Oct 3, 2024

Replaces usage of ProjectCard in project details pages with BigNumberWidget. A small refactor, to clean stuff up and try that component out. A few immediate wins:

  • consistent rounding and truncation
  • a little less code duplication
  • uncovered at least one bug
  • nicer loading and error states
  • full value on hover

Before:
Screenshot 2024-10-03 at 3 00 50 PM

After:
Screenshot 2024-10-03 at 3 02 03 PM
Screenshot 2024-10-03 at 3 07 07 PM

Closes #77780

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 3, 2024

This comment was marked as outdated.

@gggritso gggritso marked this pull request as ready for review October 3, 2024 19:46
@gggritso gggritso requested review from a team as code owners October 3, 2024 19:46
@gggritso gggritso merged commit 21ead34 into master Oct 4, 2024
45 checks passed
@gggritso gggritso deleted the ref/dashboards/use-big-number-widget-on-project-details branch October 4, 2024 13:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate into Project Details
2 participants