ref: Overhaul console integration #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our console integration was designed to work on the same page with the Spotlight UI. It was using a naive filtering method to avoid infinite loops from Spotlight debug mode logger itself. Moreover, it was not taking the `sidecarURL` option, was defaulting to `localhost:8969` as the sidecar URL. This patch overhauls the two, leveraging the fact that they are on the same page. This means switching to the local event-based message passing between the UI and the console integration, removing the need for `fetch` calls and passing around the sidecarURL option. It also overhauls the Spotlight logger to always try to use an unmodified console implementation, removing the need for hacky filtering on the console integration side.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lms24
approved these changes
Sep 13, 2024
BYK
pushed a commit
that referenced
this pull request
Sep 30, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/[email protected] ### Patch Changes - Fix race condition on event processing - prevent doubling of events ([#528](#528)) - Updated dependencies \[[`f22222717dcf2482892e1cc83c233c83ba03211d`](f222227)]: - @spotlightjs/[email protected] ## @spotlightjs/[email protected] ### Patch Changes - Fix race condition on event processing - prevent doubling of events ([#528](#528)) - Updated dependencies \[[`149e95bd02af41618bc74b365c71ddf99358672f`](149e95b), [`f22222717dcf2482892e1cc83c233c83ba03211d`](f222227)]: - @spotlightjs/[email protected] ## @spotlightjs/[email protected] ### Patch Changes - Overhaul console integration for more performance and stability ([#525](#525)) - Fix race condition on event processing - prevent doubling of events ([#528](#528)) ## @spotlightjs/[email protected] ### Patch Changes - Fix race condition on event processing - prevent doubling of events ([#528](#528)) - Updated dependencies \[[`149e95bd02af41618bc74b365c71ddf99358672f`](149e95b), [`f22222717dcf2482892e1cc83c233c83ba03211d`](f222227)]: - @spotlightjs/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our console integration was designed to work on the same page with the Spotlight UI. It was using a naive filtering method to avoid infinite loops from Spotlight debug mode logger itself. Moreover, it was not taking the
sidecarURLoption, was defaulting tolocalhost:8969as the sidecar URL. This patch overhauls the two, leveraging the fact that they are on the same page. This means switching to the local event-based message passing between the UI and the console integration, removing the need forfetchcalls and passing around the sidecarURL option. It also overhauls the Spotlight logger to always try to use an unmodified console implementation, removing the need for hacky filtering on the console integration side.ref #521.