feat: Rough in configuration files #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rough in a yaml configuration file with environment overrides. Using figment as it was used in uptime-checker and provides good ergonomics around merging configuration files with environment variables and writing tests for configuration parsing. Refs #13
markstory
commented
Nov 7, 2024
| pub sentry_env: Option<String>, | ||
|
|
||
| /// The log level to filter logging to. | ||
| pub log_level: Option<LogLevel>, |
There was a problem hiding this comment.
We'll likely need logging formatters as well. I can connect that up when I build the log integration + sentry_sdk setup.
john-z-yang
approved these changes
Nov 8, 2024
|
LGTM, let's apply the recommendation from clippy and I think it's good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rough in a yaml configuration file with environment overrides.
Using figment as it was used in uptime-checker and provides good ergonomics around merging configuration files with environment variables and writing tests for configuration parsing.
Refs #13