-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Submission: NPM (Nginx Proxy Manager) #1296
base: master
Are you sure you want to change the base?
Conversation
And remove release notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great addition @sahilph, thanks for working on this!
This is almost ready to go, there are just a few items to address below. We'll start working on gallery assets.
Co-authored-by: Nathan Fretz <[email protected]>
|
Severity | File | Description |
---|---|---|
ℹ️ | nginx-proxy-manager/docker-compose.yml |
External port mapping "40080:80": Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.). |
ℹ️ | nginx-proxy-manager/docker-compose.yml |
External port mapping "40443:443": Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.). |
nginx-proxy-manager/umbrel-app.yml |
"icon" and "gallery" needs to be empty for new app submissions: The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team. |
Legend
Symbol | Description |
---|---|
❌ | Error: This must be resolved before this PR can be merged. |
Warning: This is highly encouraged to be resolved, but is not strictly mandatory. | |
ℹ️ | Info: This is just for your information. |
@nmfretz |
App Submission
App name
Nginx Proxy Manager
DETAILED GUIDE
256x256 SVG icon
Gallery images
Image 1:
Image 2:
Image 3:
Image 4:
Note: These screenshots are taken from NPM website.
I have tested my app on:
I do not have Umbrel Home or Raspberry Pi, hence couldn't test it on them. However I have tested it on my Linux Machine (Umbrel OS 1.2.2) and it works fine.
For those who want to try it now, Nginx Proxy Manager is also available on my personal app store