Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Submission QEMU guest agent #1444

Closed
wants to merge 6 commits into from
Closed

App Submission QEMU guest agent #1444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a418d0a
adding qemu-ga-container 9.0.2
phaus Sep 8, 2024
7002df7
updating docker-compose
phaus Sep 8, 2024
0ce894a
renaming and app info update
phaus Sep 8, 2024
06a8eaa
updates based von PR feedback
phaus Sep 8, 2024
76176c7
updates based von PR feedback
phaus Sep 8, 2024
5ff3ed4
fixing tagline
phaus Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions qemu-guest-agent/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
version: "3.7"

Check notice on line 1 in qemu-guest-agent/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Potentially using unsafe user in service "agent" 

The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.

services:
agent:
image: docker.io/phaus/qemu-ga:9.0.2@sha256:1492960bef70c1d7395f7067a0092000dc30cd67bf71072a7ebd234b2dfd1221
privileged: true
network_mode: "host"

Check notice on line 7 in qemu-guest-agent/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Service "agent" uses host network mode 

The host network mode can lead to security vulnerabilities. If possible please use the default bridge network mode and expose the necessary ports.
volumes:
- "/dev:/dev"
- "/var/run/dbus/system_bus_socket:/var/run/dbus/system_bus_socket"
- "/sys/fs/cgroup:/sys/fs/cgroup"
- "/sbin/shutdown:/sbin/shutdown"
- "/bin/systemctl:/bin/systemctl"
restart: on-failure
stop_grace_period: 1m
command: ["-m", "virtio-serial", "-p", "/dev/virtio-ports/org.qemu.guest_agent.0"]
25 changes: 25 additions & 0 deletions qemu-guest-agent/umbrel-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
manifestVersion: 1
id: qemu-guest-agent
category: developer
name: QEMU guest agent
version: "9.0.2"
tagline: QEMU guest agent
description: >
This is supportive, if you want to run Umbrel as a Guest under QEMU.
It allows the QEMU host to exchange information with the guest.
This is a fork of https://github.com/dskad/qemu-ga-container to support ARM64 builds.
Details about the guest agent itself can be found here: https://wiki.qemu.org/Features/GuestAgent
This app does run as a daemon in the background and does not require a port.
The icon is [Hypervisor Icons created by Kalashnyk - Flaticon](https://www.flaticon.com/de/kostenlose-icons/hypervisor).
developer: Philipp Haußleiter
website: https://wiki.qemu.org/Features/GuestAgent
dependencies: []
repo: https://github.com/phaus/qemu-ga-container
support: https://github.com/phaus/qemu-ga-container/issues
path: ""
port: 0
gallery: []
defaultPassword: ""
releaseNotes: >
submitter: Philipp Haussleiter
submission: https://github.com/getumbrel/umbrel-apps/pull/1444