App submission mqttx web #1772
Merged
App submission mqttx web #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: port to 9010 (9001=mqtt via websockets and left some space) fix: description fix: support-url
fix: added user: "1000:1000" instead of environment
|
| Severity | File | Description |
|---|---|---|
mqttx-web/umbrel-app.yml |
"icon" and "gallery" needs to be empty for new app submissions: The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team. |
Legend
| Symbol | Description |
|---|---|
| ❌ | Error: This must be resolved before this PR can be merged. |
| Warning: This is highly encouraged to be resolved, but is not strictly mandatory. | |
| ℹ️ | Info: This is just for your information. |
|
Thanks for the changes @dirstel! Really great work on this submission. I have made some final tweaks and we are ready to go live 🎉 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App Submission
MQTTX Web
256x256 SVG icon
https://github.com/emqx/MQTTX/blob/main/web/public/icons/app.png
Gallery images
https://github.com/emqx/MQTTX/blob/main/assets/mqttx-web-preview.png
https://github.com/emqx/MQTTX/blob/main/assets/mqttx-connection.png
https://github.com/emqx/MQTTX/blob/main/assets/mqttx-muti-topics.png
I have tested my app on: