Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add romm #2020

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Feat/add romm #2020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5331dd3
first commit: add romm
mateosilguero Aug 29, 2023
030a23c
replace files content
mateosilguero Sep 25, 2023
c0f5497
Change app port
mateosilguero Sep 25, 2023
f34644a
update romm to 3.6.0
mateosilguero Jan 7, 2025
74e28dc
umbrel-app
mateosilguero Jan 7, 2025
14beab8
romm 3.7.2
mateosilguero Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions romm/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
version: '3.7'

Check notice on line 1 in romm/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Potentially using unsafe user in service "server" 

The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.

Check notice on line 1 in romm/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Potentially using unsafe user in service "romm-db" 

The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.
services:
app_proxy:
environment:
APP_HOST: romm_server_1
APP_PORT: 8080
PROXY_AUTH_ADD: 'true'
container_name: romm_app_proxy_1
server:
image: rommapp/romm:3.7.2@sha256:b3d593308f2d79a47c63219c20fdad1d6f17de2dee97cbad2aa748ef1d279484
volumes:

Check notice on line 11 in romm/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Mounted file/directory "/romm/data/resources" doesn't exist 

The volume "${APP_DATA_DIR}/data/resources:/romm/resources" tries to mount the file/directory "/romm/data/resources", but it is not present. This can lead to permission errors!

Check notice on line 11 in romm/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Mounted file/directory "/romm/data/redis" doesn't exist 

The volume "${APP_DATA_DIR}/data/redis:/redis-data" tries to mount the file/directory "/romm/data/redis", but it is not present. This can lead to permission errors!

Check notice on line 11 in romm/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Mounted file/directory "/romm/data/library" doesn't exist 

The volume "${APP_DATA_DIR}/data/library:/romm/library" tries to mount the file/directory "/romm/data/library", but it is not present. This can lead to permission errors!

Check notice on line 11 in romm/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Mounted file/directory "/romm/data/assets" doesn't exist 

The volume "${APP_DATA_DIR}/data/assets:/romm/assets" tries to mount the file/directory "/romm/data/assets", but it is not present. This can lead to permission errors!

Check notice on line 11 in romm/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Mounted file/directory "/romm/data/config" doesn't exist 

The volume "${APP_DATA_DIR}/data/config:/romm/config" tries to mount the file/directory "/romm/data/config", but it is not present. This can lead to permission errors!
- ${APP_DATA_DIR}/data/resources:/romm/resources
- ${APP_DATA_DIR}/data/redis:/redis-data
- ${APP_DATA_DIR}/data/library:/romm/library
- ${APP_DATA_DIR}/data/assets:/romm/assets
- ${APP_DATA_DIR}/data/config:/romm/config
restart: on-failure
depends_on:
romm-db:
condition: service_healthy
restart: true
environment:
- DB_HOST=romm_romm-db_1
- DB_NAME=romm
- DB_USER=romm-user
- DB_PASSWD=moneyprintergobrr
- ROMM_AUTH_SECRET_KEY=ROMM_AUTH_SECRET_KEY
- ROMM_AUTH_USERNAME=admin
- ROMM_AUTH_PASSWORD=admin
- IGDB_CLIENT_ID=IGDB_CLIENT_ID
- IGDB_CLIENT_SECRET=IGDB_CLIENT_SECRET
container_name: romm_server_1
romm-db:
image: mariadb:latest

Check failure on line 34 in romm/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Invalid image name "mariadb:latest" 

Images should be named like "<name>:<version-tag>@<sha256>"
restart: unless-stopped

Check warning on line 35 in romm/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Invalid restart policy 

The restart policy of the container "romm-db" should be set to "on-failure".
environment:
- MYSQL_ROOT_PASSWORD=umbrel
- MYSQL_DATABASE=romm
- MYSQL_USER=romm-user
- MYSQL_PASSWORD=moneyprintergobrr
volumes:

Check notice on line 41 in romm/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Mounted file/directory "/romm/data/mysql" doesn't exist 

The volume "${APP_DATA_DIR}/data/mysql:/var/lib/mysql" tries to mount the file/directory "/romm/data/mysql", but it is not present. This can lead to permission errors!
- ${APP_DATA_DIR}/data/mysql:/var/lib/mysql
healthcheck:
test: ["CMD", "healthcheck.sh", "--connect", "--innodb_initialized"]
start_period: 30s
start_interval: 10s
interval: 10s
timeout: 5s
retries: 5
container_name: romm_romm-db_1
25 changes: 25 additions & 0 deletions romm/umbrel-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
manifestVersion: 1
id: romm
category: files
name: RomM
icon: https://github.com/rommapp/romm/blob/release/.github/resources/isotipo.svg

Check warning on line 5 in romm/umbrel-app.yml

View workflow job for this annotation

GitHub Actions / Lint apps

"icon" and "gallery" needs to be empty for new app submissions 

The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team.
version: "3.7.2"
tagline: Rom Manager
description: >-
RomM (Rom Manager) is a web based retro roms manager integrated with IGDB.
releaseNotes:

Check failure on line 10 in romm/umbrel-app.yml

View workflow job for this annotation

GitHub Actions / Lint apps

releaseNotes 

Expected string, received null
developer: rommapp
website: https://github.com/rommapp/romm
repo: https://github.com/rommapp/romm
support: https://github.com/rommapp/romm/issues
port: 4002
submitter: Mateo Silguero
submission: https://github.com/getumbrel/umbrel-apps/pull/2020
gallery:
- 1.jpg
- 2.jpg
- 3.jpg
dependencies: []
path: ""
defaultUsername: ""
defaultPassword: ""
Loading