Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve: Added Github Action CI #78

Merged
merged 1 commit into from
Apr 18, 2024
Merged

improve: Added Github Action CI #78

merged 1 commit into from
Apr 18, 2024

Conversation

jylamont
Copy link
Contributor

@jylamont jylamont commented Apr 17, 2024 •
edited
Loading

We previously used TravisCI to run specs. This PR replaces this with a Github Action. It also removes the version locks on development dependencies as they are very old.

This was referenced Apr 17, 2024
Merged
Merged
@jylamont Graphite App
Copy link
Contributor Author

jylamont commented Apr 17, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jylamont and the rest of your teammates on Graphite Graphite

This was referenced Apr 17, 2024
Merged
Merged
@jylamont jylamont force-pushed the 04-17-improve_added_github_action_ci branch from 939b9aa to ea3dfee Compare April 17, 2024 22:45
@jylamont jylamont requested a review from edubkendo April 17, 2024 22:47
@jylamont jylamont marked this pull request as ready for review April 17, 2024 22:47
@jylamont jylamont mentioned this pull request Apr 17, 2024
Open
edubkendo
edubkendo approved these changes Apr 17, 2024
View reviewed changes
Copy link

@edubkendo edubkendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It's a shame there's no way to just hand circleCI a list of ruby versions and then write the boilerplate for running specs once.

@jylamont Graphite App
Copy link
Contributor Author

Good point @edubkendo, there very likely is. I'll take a look before merging.

@jylamont jylamont force-pushed the 04-17-improve_added_github_action_ci branch from ea3dfee to e4579a9 Compare April 18, 2024 00:02
@jylamont Graphite App
Copy link
Contributor Author

jylamont commented Apr 18, 2024 •
edited
Loading

Merge activity

  • Apr 17, 8:03 PM EDT: @jylamont started a stack merge that includes this pull request via Graphite.
  • Apr 17, 8:10 PM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 17, 8:11 PM EDT: @jylamont merged this pull request with Graphite.

@jylamont jylamont force-pushed the 04-17-chore_run_rubocop_over_existing_code branch from dc29935 to a35b33a Compare April 18, 2024 00:07
Base automatically changed from 04-17-chore_run_rubocop_over_existing_code to master April 18, 2024 00:09
@jylamont jylamont force-pushed the 04-17-improve_added_github_action_ci branch from e4579a9 to a3c498e Compare April 18, 2024 00:10
@jylamont jylamont merged commit 1f26a6e into master Apr 18, 2024
7 checks passed
@jylamont jylamont deleted the 04-17-improve_added_github_action_ci branch April 18, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edubkendo edubkendo edubkendo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jylamont @edubkendo