added metadata to crowding, edited process_resp #91
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
- Coverage 97.85% 96.55% -1.31%
==========================================
Files 51 52 +1
Lines 2288 2324 +36
==========================================
+ Hits 2239 2244 +5
- Misses 49 80 +31 ☔ View full report in Codecov by Sentry. |
main to metadata
R/demo-crowding.R
Outdated
| result_df <- process_metadata(resp) | ||
|
|
||
| } else { | ||
| resp %>% | ||
| setNames(c( | ||
| get_area(areatype), | ||
| "Percent", | ||
| "Households", | ||
| "Rank" | ||
| )) %>% | ||
| mutate(across(c("Percent", "Households"), \(x) as.numeric(x))) |
There was a problem hiding this comment.
It isn't immediately clear that this function returns result_df if include_metadata == TRUE and returns the output of the else statement if include_metadata == FALSE.
I would assign the output of running the dplyr verbs to result_df and then return result_df at the very last line of this function.
R/demo-education.R
Outdated
| result_df <- process_metadata(resp) | ||
|
|
||
| } else { | ||
| resp %>% | ||
| setNames(c( | ||
| get_area(areatype), | ||
| "Percent", | ||
| "Households", | ||
| "Rank" | ||
| )) %>% | ||
| mutate(across(c("Percent", "Households"), \(x) as.numeric(x))) | ||
| } |
There was a problem hiding this comment.
Same comments as the ones left in demo_crowding.R
edited get metadata functions
Get metadata function
main to metadata
Hey @seankross, @howardbaek
Please checkout the new addition of metadata in cancerprof, I edited process_resp to be able to produce metadata information as a list of chars ad output the metadata and the dataframe in a list. So far, Ive only added the include_metadata parameter to demo_crowding.
Please let me know with any feedback!