Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploratory walkthrough of data ingestion / viz from cancerprof and a basic Shiny app #3

Open
wants to merge 20 commits into
base: dev
Choose a base branch
from

Conversation

vsriram24
Copy link
Collaborator

Includes R code in QMD files to explore data ingestion, munging, and visualization (using {leaflet} and {tmap}) for cancer incidence data. Also includes directories of publicly-sourced shape files for geospatial data visualization.

Next steps are to comment / clean code as well as remove any hard-coded elements, and then port this over into a Shiny app so that data visualization can be explored further.

@vsriram24 vsriram24 marked this pull request as ready for review September 18, 2024 22:59
@vsriram24
Copy link
Collaborator Author

This branch also includes the creation of a basic Shiny app.

@vsriram24 vsriram24 changed the title Exploratory walkthrough of data ingestion and viz from cancerprof Exploratory walkthrough of data ingestion / viz from cancerprof and a basic Shiny app Sep 20, 2024
@vsriram24 vsriram24 added enhancement New feature or request good first issue Good for newcomers labels Sep 20, 2024
R/app.R Show resolved Hide resolved
#' )
#'

get_incidence_db_name <- function(cancer, race, sex, age, stage, year){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should talk about this database schema, I'm not convinced this is the best way forward.

@seankross
Copy link
Contributor

Generally speaking this is a great start. Both of my main comments are pretty high level, let's chat about it when you get the chance.

@seankross seankross mentioned this pull request Sep 23, 2024
@vsriram24
Copy link
Collaborator Author

@seankross data ingestion now exists separately from the Shiny app. The latest updates on this branch include a separate pipeline that ingests SCP Washington state county-level data and puts it into the Fred Hutch postgreSQL database. Let me know your feedback on this PR when you have the chance.

@seankross
Copy link
Contributor

Hey @vsriram24, unfortunately I am just now getting to this. Which files do I need to run in what order to get the Shiny app to work?

@vsriram24
Copy link
Collaborator Author

vsriram24 commented Oct 10, 2024

Hi @seankross, for this branch, there's no need to worry about the Shiny app. You can just run R/ingest-scp.R to evaluate the data ingestion pipeline. Note that you will have to create a .Renviron file within the oncarto/ directory that contains the postgreSQL database information for the data saving step at the end of the script to work. I'll include a comment in the baseline-app PR to explain how to run the Shiny app.

@seankross
Copy link
Contributor

@vsriram24 in that case I am only going to give feedback on R/ingest-scp.R in this PR unless you want feedback on other changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants