New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exports: ESM & CJS multi-module #24

Open

pubkey wants to merge 2 commits into gfodor:master from pubkey:master

+16 −2

pubkey commented Nov 23, 2023 •

edited

Loading

This PR changes the build scripts so that this package can be used either as esm module or as cjs package at the same time.

This fixes #21 while making it still usable for everyone who is still on cjs modules.

Questions:

Would you accept a PR to add a CI via github actions with some tests?
Would you accept a PR to add typescript typings (or even rewrite the code to typescript)?
Would you accept a PR to have a node.js fallback where the global window variable is not defined?

pubkey added 2 commits

November 23, 2023 01:09


          CHANGE esm and cjs multi-module

fb8ea1d


          FIX type:module

84894ec

pubkey mentioned this pull request

Feature/replication p2pcf pubkey/rxdb#5305

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet