Remove unused objc_exception
dependency
#303
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one unused
objc_exception
dependency is preventing docs from building on docs.rs, becausecc
tries to pass-arch
, to GCC, which doesn't see it as a valid argument, when buildingobjc-exception
.Except,
objc-exception
doesn't really do anything in metal-rs. I grepped for all of the functions exported byobjc-exception
, and found nothing at all. I then rancargo check --target=x86_64-apple-darwin
cargo check --target=aarch64-apple-ios
cargo check --target=aarch64-apple-darwin
On both Windows and Linux and it passed with flying colours. To be sure, I checked the source of the
objc
crate crate, where theexception
feature only brings inobjc-exception
and thiscatch_exception
function. There are no special linkage parameters thatobjc_exception
provides nor is it used at all by metal-rs and thus wgpu.There's no reason to keep this around especially because its the only reason docs are breaking for it. It's causing trouble for downstream consumers of libraries that use wgpu, I've had to resort to workarounds like
#[cfg(all(target_vendor = "apple", feature = "docsrs"))]
to remove wgpu dependencies on my macOS docs build chain.This should fix gfx-rs/wgpu#2956, #5 , and obviate #250
I've also fixed a
static_mut_ref
warning that cargo was complaining about.