Disable default link feature on core-graphics-types
#330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `link` feature was forwarded to `core-graphics-types` in its update in gfx-rs#297, it wasn't taken into account that the feature was enabled by default in https://togithub.com/servo/core-foundation-rs/pull/608, leading to the `link` feature to always remain enabled even if `default-features` are **disabled** on the `metal` crate. Disable the `link` feature by default on `core-graphics-types`, and rely on our (default-enabled) `link` feature to turn it back on from inside `metal`.
MarijnS95
added a commit
to Traverse-Research/saxaboom
that referenced
this pull request
Jul 16, 2024
Since we're only using a few types from the `metal` crate, this helper library has no reason or need to link against framework libraries (i.e. we don't call global static functions on them). Disable the `link` feature on the `metal` crate, but note that for now this won't disable it on the `core-graphics-types` crate until gfx-rs/metal-rs#330 is merged.
This was referenced Jul 16, 2024
cwfitzgerald
approved these changes
Jul 17, 2024
MarijnS95
added a commit
to Traverse-Research/saxaboom
that referenced
this pull request
Jul 23, 2024
Since we're only using a few types from the `metal` crate, this helper library has no reason or need to link against framework libraries (i.e. we don't call global static functions on them). Disable the `link` feature on the `metal` crate, but note that for now this won't disable it on the `core-graphics-types` crate until gfx-rs/metal-rs#330 is merged.
github-merge-queue bot
pushed a commit
to Traverse-Research/saxaboom
that referenced
this pull request
Jul 23, 2024
Since we're only using a few types from the `metal` crate, this helper library has no reason or need to link against framework libraries (i.e. we don't call global static functions on them). Disable the `link` feature on the `metal` crate. > [!CAUTION] > For now this won't disable it on the `core-graphics-types` crate until gfx-rs/metal-rs#330 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
linkfeature was forwarded tocore-graphics-typesin its update in #297, it wasn't taken into account that the feature was enabled by default in https://togithub.com/servo/core-foundation-rs/pull/608, leading to thelinkfeature to always remain enabled even ifdefault-featuresare disabled on themetalcrate.Disable the
linkfeature by default oncore-graphics-types, and rely on our (default-enabled)linkfeature to turn it back on from insidemetal.