Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline document-features usage, remove dep. #4924

Commits on Dec 22, 2023

  1. docs: inline document-features usage, remove dep.

    Re-implements gfx-rs#4886 (CC @Wumpf)
    without the `document-features` crate, which has issues integrating into
    Firefox builds after being `cargo vendor`ed into its repository. This
    issue is being tracked against
    slint-ui/document-features#20. Once resolved,
    I expect that we will want to revert this PR in its entirety, since
    `document-features` is still a good addition to `wgpu`'s documentation
    story.
    
    Internally, consensus has already been achieved for this change.
    Firefox's ability to build unfortunately take priority over this
    particular convenience. Hopefully, we won't have to compromise shortly!
    
    I tested this by ensuring that the HTML output of our existing
    `document_features::document_features!(…)` usage was exactly the same.
    There should be exactly zero regressions in the current state of
    documentation for users. For maintainers, I have added a disclaimer that
    one needs to keep changes in sync. with the relevant `Cargo.toml`
    manifests.
    ErichDonGubler committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    2e3c648 View commit details
    Browse the repository at this point in the history