Revert "docs: inline document-features usage, remove dep."
#5169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
added
the
area: documentation
ErichDonGubler
commented
Jan 31, 2024
ErichDonGubler
commented
Jan 31, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ErichDonGubler
force-pushed
the
unrevert-document_features
branch
from
60bec3f
to
328bf55
Compare
This reverts commit 3d5bec6, with an update to `document-features`, and preferring to keep new `feature` content. To be clear, the only difference I have observed is the addition of the `serde` feature. In case it shortens anyone's search, the specific issue resolved is [`slint-ui/document-features`#20](slint-ui/document-features#20).
ErichDonGubler
force-pushed
the
unrevert-document_features
branch
from
328bf55
to
44b96c1
Compare
Wumpf
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3d5bec6, with an update to
document-features, and preferring to keep newfeaturecontent. To be clear, the only difference I have observed is the addition of theserdefeature.Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
As stated in the commit message: (hopefully intelligently) reverts #4924.
Description
Describe what problem this is solving, and how it's solved.
Testing
Explain how this change is tested.
This is tested by checking docs.
Checklist
Runcargo fmt.Runcargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptenRuncargo xtask testto run tests.Add change toCHANGELOG.md. See simple instructions inside file.