Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added comment explaining group norm behavior in ggml.h #813

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions include/ggml/ggml.h
Original file line number Diff line number Diff line change
Expand Up @@ -1136,6 +1136,10 @@ extern "C" {

// group normalize along ne0*ne1*n_groups
// used in stable-diffusion
// calculated over first 2 dimensions
// To get normalization on first dimension only (pytorch default behavior),
// you can move the second dimension of tensor a to the third.
// https://github.com/ggerganov/ggml/issues/803
// TODO: eps is hardcoded to 1e-6 for now
GGML_API struct ggml_tensor * ggml_group_norm(
struct ggml_context * ctx,
Expand Down
Loading