test: fix OPT_STEP_ADAMW for test-backend-ops #974
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup for #966 .
When I tested
GGML_OP_OPT_STEP_ADAMW
I had mistyped the filter fortest-backend-ops
so I didn't notice that the test is broken. The problem is that the gradients for tensors are no longer being allocated unless a backward graph is constructed. This can simply be fixed by explicitly creating a tensor the gradients. Also I'm changing the interface forggml_opt_step_adamw
to accept a gradient tensor since the long term goal forggml_tensor.grad
is to remove it.