Add .clang-format file #10308
Open
Add .clang-format file #10308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So people can use things like clang-format and git clang-format to style their code. Copied from ggml-cann, with PointerAlignment changed to Middle. Signed-off-by: Eric Curtin <[email protected]>
|
Example of PR styled with this .clang-format file: |
ggerganov
reviewed
Nov 15, 2024
Co-authored-by: Georgi Gerganov <[email protected]> Signed-off-by: Eric Curtin <[email protected]>
ericcurtin
force-pushed
the
clang-format
branch
from
c09aca3
to
25380ef
Compare
|
I am not convinced that this is any better than starting from scratch. I may spend time on the next days trying to make one that we can use on every file, it would save a lot of time and fix all the minor formatting inconsistencies that are present in nearly every PR from new contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So people can use things like clang-format and git clang-format to style their code. Copied from ggml-cann, with PointerAlignment changed to Middle.