Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore : Fix the error when compiling rocm build on windows using cmake #10310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cocochick
Copy link

@cocochick cocochick commented Nov 15, 2024

(#9666)

Fix the compilation error "call to undeclared function '_mm256_dpbusd_epi32'". The function _mm256_dpbusd_epi32 is defined in avxintrin.h, while _mm256_dpbusd_epi32 is defined in avx512vlvnniintrin.h. Therefore, AVX, AVX512VNNI, and AVX512VL need to be defined.

According to (#7743), DGGML_OPENMP=OFF is needed to add, so adding it in doc.

 (ggerganov#9666)

Fix the compilation error "call to undeclared function '_mm256_dpbusd_epi32'". The function _mm256_dpbusd_epi32 is defined in avxintrin.h, while _mm256_dpbusd_epi32 is defined in avx512vlvnniintrin.h. Therefore, __AVX__, __AVX512VNNI__, and __AVX512VL__ need to be defined.

According to (ggerganov#7743), DGGML_OPENMP=OFF is needed to add, so adding it in doc.
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 15, 2024
@slaren
Copy link
Collaborator

slaren commented Nov 16, 2024

Shouldn't AVX always be available in machines with AVX512? If AVX is not being enabled, that might indicate a problem in the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants