Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Implement GGUF #2397

Merged
merged 2 commits into from
Jul 26, 2023
Merged

WIP: Implement GGUF #2397

merged 2 commits into from
Jul 26, 2023

Conversation

monatis
Copy link
Collaborator

@monatis monatis commented Jul 26, 2023

Implementing Python writer and C reader for GGUF defined in ggerganov/ggml#302

This is still WIP

This is still WIP and I'm raising the PR for discussions and feedback.

I'm trying to be fast and provide a maintainable code at the same time, so the current state may look a little bit messy, but I'll put everything to a proper order as the implementation gets mature.

@ggerganov ggerganov changed the base branch from master to gguf July 26, 2023 08:16
@ggerganov ggerganov marked this pull request as ready for review July 26, 2023 08:16
@ggerganov ggerganov merged commit 6d3c786 into ggerganov:gguf Jul 26, 2023
ggerganov pushed a commit that referenced this pull request Jul 26, 2023
* Add LLAMA_DEFAULT_RMS_EPS so we can change the default (#2384)

Co-authored-by: Iwan Kawrakow <[email protected]>

* WIP: python class to write GGUF, incomplete C apı for reading

---------

Co-authored-by: Kawrakow <[email protected]>
Co-authored-by: Iwan Kawrakow <[email protected]>
@ggerganov
Copy link
Owner

Merged this in the new #2398 branch - will try to make an iteration over this in the next couple of days

ggerganov pushed a commit that referenced this pull request Jul 26, 2023
* Add LLAMA_DEFAULT_RMS_EPS so we can change the default (#2384)

Co-authored-by: Iwan Kawrakow <[email protected]>

* WIP: python class to write GGUF, incomplete C apı for reading

---------

Co-authored-by: Kawrakow <[email protected]>
Co-authored-by: Iwan Kawrakow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants