Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: code cleanup & simpler html struct object #156

Merged
merged 3 commits into from
Nov 9, 2023
Merged

chore: code cleanup & simpler html struct object #156

merged 3 commits into from
Nov 9, 2023

Conversation

ghiscoding
Copy link
Owner

  • define html struct prop even with null props, we'll now remove null props before calling createDomElement to avoid creating empty HTML class/title/...

@ghiscoding
chore: code cleanup & simpler html struct object
71e9c8e 
- define html struct prop even with null props, we'll now remove null props before calling createDomElement to avoid creating empty HTML class/title/...
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023 •
edited
Loading

🎭 Playwright Summary - Success 🎉

Playwright Report

[email protected] test:e2e /home/runner/work/multiple-select-vanilla/multiple-select-vanilla
playwright test --config playwright/playwright.config.ts

Running 69 tests using 2 workers
·····································································
69 passed (54.7s)

@ghiscoding ghiscoding merged commit 63faead into main Nov 9, 2023
2 checks passed
@ghiscoding ghiscoding deleted the chore/html-struct-cleanup branch November 9, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ghiscoding