Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input checkbox value should always be included even when null #158

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

ghiscoding
Copy link
Owner

  • last version refactoring removed all empty props & attributes when creating DOM element but we should never remove input value prop even when it is null or empty

Copy link

🎭 Playwright Summary - Success 🎉

Playwright Report

[email protected] test:e2e /home/runner/work/multiple-select-vanilla/multiple-select-vanilla
playwright test --config playwright/playwright.config.ts

Running 69 tests using 1 worker
·····································································
69 passed (2.0m)

@ghiscoding ghiscoding merged commit 4d33cff into main Nov 10, 2023
2 checks passed
@ghiscoding ghiscoding deleted the bugfix/element-remove-certain-props branch November 10, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant