Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: package has no side effect #169

Closed
wants to merge 1 commit into from
Closed

Conversation

ghiscoding
Copy link
Owner

No description provided.

Copy link

🎭 Playwright Summary - Success 🎉

Playwright Report

[email protected] test:e2e /home/runner/work/multiple-select-vanilla/multiple-select-vanilla
playwright test --config playwright/playwright.config.ts

Running 69 tests using 2 workers
·····································································
69 passed (58.6s)

@ghiscoding
Copy link
Owner Author

hmmm after more investigation, it looks like attaching to the window object, which we do, is a side effect

Examples of side effects:
Angular binds to the global window object, but doesn't export anything.
A polyfill that enables ES6 features in the browsers that don't support them, like babel polyfill is a side effect.
Many jQuery plugins attach themselves to the global jQuery object.
Analytics modules that run in the background, monitor user interaction, and send the data to a server.
Importing CSS in webpack can be considered a side effect if you're not using CSS modules.

@ghiscoding ghiscoding closed this Nov 14, 2023
@ghiscoding ghiscoding deleted the chore/side-effect branch November 23, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant