Feature: custom media sizes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files that require special permissions, such as those in ".github" or "tests/" directories, are usually not necessary for the update.
- Integrated `resize_image` function to dynamically resize game icons based on request parameters. - Updated `get_game_icon` function to use the resized image path. - Modified the `get_nx` endpoint to handle width and height parameters for icon requests. - Updated readme
- Moved `nearest_size` function utilization to ensure width and height are valid sizes before resizing. - Added headers to the response for icon requests to include content type, width, height, and filename. - Updated imports to include `nearest_size` in `main.py`.
Raised HTTP 422 error if width or height are not valid integers.
- Added support for custom banner dimensions in the `/banner` endpoint. - Updated `resize_image` function to handle default banner sizes and maintain aspect ratio. - Modified `get_game_banner` to use the resized image path. - Updated README to reflect changes in banner endpoint usage.
- Corrected the error message for invalid width values in the banner endpoint. - Removed debug print statements. - Added a check to raise an HTTP 422 error if the resolution is not accepted instead of 'banner not found'.
Updated `get_game_icon` and `get_game_banner` functions to return None if the requested resolution is not supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dynamic resizing for game icons and banners
GET api.nlib.cc/nx/[tid]/icon/[width]/[height]Returns the game icon. If
widthandheightare not specified, the default size of 1024x1024 JPEG is returned.GET api.nlib.cc/nx/[tid]/banner/[width]/[height]Returns the game banner. Supported sizes are 1920x1080 and 1280x720. You can also use
/banner/720por/banner/1080p. If neitherwidthnorheightis specified, the default size of 1920x1080 JPEG is returned.