Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to mark packages as vital packages #204

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

ericbsd
Copy link
Member

@ericbsd ericbsd commented Sep 10, 2024

Resolves ghostbsd/issues#169

Summary by Sourcery

Introduce functionality to mark certain packages as vital in the build script, ensuring they are treated with higher priority during installation.

New Features:

  • Add support for marking packages as vital during the build process.

Enhancements:

  • Refactor the build script to separate vital packages from regular packages for both base and software installations.

@ericbsd ericbsd requested review from a team as code owners September 10, 2024 00:54
@ericbsd ericbsd self-assigned this Sep 10, 2024
Copy link
Contributor

sourcery-ai bot commented Sep 10, 2024

Reviewer's Guide by Sourcery

This pull request adds support for marking packages as vital packages in the GhostBSD build process. It modifies the base and packages_software functions to include a new step that sets certain packages as vital.

File-Level Changes

Change Details Files
Introduce vital package marking in the base function
  • Add new variables 'vital_base' to store vital base packages
  • Load vital base packages from new files in the 'packages/vital/' directory
  • Add a new pkg-static command to set vital flags for base packages
build.sh
Implement vital package marking in the packages_software function
  • Rename 'pkg_list' variable to 'packages' for clarity
  • Add new 'vital_packages' variable to store vital software packages
  • Load vital software packages from new files in the 'packages/vital/' directory
  • Split package installation and vital package marking into separate commands
build.sh
Minor code cleanup and formatting changes
  • Remove an empty line near the beginning of the file
  • Add missing space in a variable expansion
  • Adjust indentation and line breaks for better readability
build.sh

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericbsd - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding inline comments to explain the purpose of the new 'vital' package lists and the significance of setting the vitality flag to 1.
  • It would be beneficial to add error handling for cases where the vital package lists might be empty or the 'set' command fails.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@ericbsd ericbsd merged commit 1cd1556 into master Sep 10, 2024
2 checks passed
@ericbsd ericbsd deleted the issue_#169 branch September 10, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Set our system and software packages has vital packages
1 participant