Removed os related ports and move os/ports to into sysutils #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request removes OS-related ports and moves the 'ports' port to the 'sysutils' category. It involves changes to several Makefiles, removal of multiple OS-related files, and updates to category listings. File-Level Changes
Tips
|
ericbsd
changed the title
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ericbsd - I've reviewed your changes - here's some feedback:
Overall Comments:
- This is a significant restructuring of the ports system. Please provide a more detailed explanation of the motivation behind these changes and their potential impacts on existing systems.
- The removal of the RUN_DEPENDS on userland-devtools needs clarification. How is this dependency being handled now?
- For such a major change, please outline the testing process and any migration plans for existing systems that may be affected by this restructuring.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
ericbsd
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve ghostbsd/issues#167
Summary by Sourcery
Reorganize the project structure by moving ports from the 'os' category to 'sysutils', and remove the 'os' category along with its related files and scripts.
Enhancements:
Chores: