Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mount_be stdout. #7

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Fixed mount_be stdout. #7

merged 1 commit into from
Jul 26, 2024

Conversation

ericbsd
Copy link
Member

@ericbsd ericbsd commented Jul 26, 2024

Summary by Sourcery

This pull request addresses a bug in the mount_be function by ensuring that the stdout of the subprocess is captured.

  • Bug Fixes:
    • Fixed the issue where the stdout of the mount_be function was not being captured.

@ericbsd ericbsd requested review from a team as code owners July 26, 2024 10:51
Copy link

sourcery-ai bot commented Jul 26, 2024

Reviewer's Guide by Sourcery

This pull request fixes the handling of stdout in the 'mount_be' function by adding 'stdout=PIPE' to the 'run' function call. This change ensures that the standard output of the 'bectl' command is captured correctly.


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericbsd - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider capturing stderr as well as stdout to ensure all output from the subprocess is captured.
  • The function returns a string, but the captured output isn't being used. Consider updating the function to return the captured output if that's the intended behavior.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@ericbsd ericbsd merged commit 1c6ccc2 into master Jul 26, 2024
1 check passed
@ericbsd ericbsd deleted the fix-bectl branch July 26, 2024 10:55
@ericbsd ericbsd added the bug Something isn't working label Aug 5, 2024
@ericbsd ericbsd self-assigned this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant