feat: extended bit window in NetworkFilter
#4509
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a concept of
sourceMask
to extendmask
ofNetworkFilter
from 32 bits to 48 bits (16+32). With this changes, we are able to keep supporting more options inNetworkFilter
.For the backward compatibility issues, we may accept two kinds of arguments from
NetworkFilter
then process them separately. For an instance, we can acceptnumber | [number, number]
in the argument object of the constructor function. Then we can build two corresponding mask from a singlenumber
depending on the previous format ifnumber
was given.With this structure, we can avoid breaking legacies.