fix(adblocker): inject scriptlets from source code #2119
Merged
+754
−432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalluban
requested changes
Dec 6, 2024
chrmod
force-pushed
the
ubo-scriptlets
branch
2 times, most recently
from
d4dd62a to
e0cab72
Compare
smalluban
reviewed
Dec 10, 2024
smalluban
changed the title
chrmod
force-pushed
the
ubo-scriptlets
branch
from
b995d85 to
2d2afa8
Compare
|
Builds for commit 2d2afa8: |
smalluban
reviewed
Dec 10, 2024
philipp-classen
approved these changes
Dec 10, 2024
chrmod
force-pushed
the
ubo-scriptlets
branch
from
2d2afa8 to
026b0d0
Compare
|
Builds for commit 026b0d0: |
smalluban
approved these changes
Dec 10, 2024
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instagram.com and facebook.com introduced strict CSP that prevent current scriplet injection method that we use currently. To bypass those restrictions we have to pass scritpelts as code with help of
chrome.scripting.executeScript.This however require us to ship the scriptlets and evaluate them in the background context.
A new repository to provide scriptlet code is created https://github.com/ghostery/scriptlets. As its code comes from other project like uBO, there is no need for any kind of versioning scheme so we will use git commit checksums instead and install from github directly.
As this means we have to ship GPL code with the extension, we are forced to switch license from MPL-v2 to GPL-v3.
Please test on facebook.com, instagram.com and youtube.com.