Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghostery: 3.2.0 #1277

Merged
merged 16 commits into from
Aug 23, 2023
Merged

Ghostery: 3.2.0 #1277

merged 16 commits into from
Aug 23, 2023

Conversation

smalluban
Copy link
Contributor

@smalluban smalluban commented Aug 16, 2023 •
edited by chrmod
Loading

Fixes https://github.com/ghostery/journal/issues/147

Use rebase when merging.

Additional changes:

  • Builds on Apple silicon
  • uses ASDF to manage nodejs and ruby version
  • Basic CI with Github Action
  • hardcodes signing certificates for Ghostery release
  • update swiftlint

@smalluban smalluban requested a review from chrmod August 16, 2023 10:02
@chrmod chrmod force-pushed the ghostery-update-brand branch 9 times, most recently from e303e56 to 54e4d97 Compare August 21, 2023 19:36
@chrmod chrmod changed the title Update brand Ghostery: 3.2.0 Aug 21, 2023
@chrmod chrmod marked this pull request as draft August 21, 2023 20:47
@chrmod chrmod marked this pull request as ready for review August 22, 2023 08:57
@smalluban smalluban merged commit c4d123e into main Aug 23, 2023
1 check passed
@smalluban smalluban deleted the ghostery-update-brand branch August 23, 2023 08:47
@GRadziejewski
Copy link

GRadziejewski commented Sep 7, 2023 •
edited
Loading

Iteration nr 1.

Smoke tests on desktop

Smoke tests on mobile

  • Browser: Ghostery Private Browser 3.2.0 (3)
    OS: iOS 16.6.1 (iPhone 13)

    Checked features

    • Install fresh (no profiles and etc)
    • Update
    • Ghostery cannot work before onboarding
    • Onboarding
      Enable/Disable Ghostery
    • Enable/Disable Ad-blocking
    • Enable/Disable Anti-tracking
    • Pause Ghostery
    • Never Consent
    • Trackers Preview
      Select/Unselect any/all tracker/s
      Sign in/out
      Sign in and then update
      Check Sync from / into another device
      Check Ghostery Settings logs
      Check Ghostery Background logs
      Check account settings
    • Log into Google account and open google.com
      • Try to search anything
      • Try to search something with video
    • Log into FB
      Update of the GBE
    • Other (from PR)

  • Browser: Ghostery Private Browser 3.2.0 (3)
    OS: iOS 16.6.1 (iPhone XR)

    Checked features

    • Install fresh (no profiles and etc)
    • Update
    • Ghostery cannot work before onboarding
    • Onboarding
      Enable/Disable Ghostery
    • Enable/Disable Ad-blocking
    • Enable/Disable Anti-tracking
    • Pause Ghostery
    • Never Consent
    • Trackers Preview
      Select/Unselect any/all tracker/s
      Sign in/out
      Sign in and then update
      Check Sync from / into another device
      Check Ghostery Settings logs
      Check Ghostery Background logs
      Check account settings
    • Log into Google account and open google.com
      • Try to search anything
      • Try to search something with video
    • Log into FB
      Update of the GBE
    • Other (from PR)

  • Browser: Ghostery Private Browser 3.2.0 (3)
    OS: iOS 15.7.8 (iPhone SE)

    Checked features

    • Install fresh (no profiles and etc)
    • Update
    • Ghostery cannot work before onboarding
    • Onboarding
      Enable/Disable Ghostery
    • Enable/Disable Ad-blocking
    • Enable/Disable Anti-tracking
    • Pause Ghostery
    • Never Consent
    • Trackers Preview
      Select/Unselect any/all tracker/s
      Sign in/out
      Sign in and then update
      Check Sync from / into another device
      Check Ghostery Settings logs
      Check Ghostery Background logs
      Check account settings
    • Log into Google account and open google.com
      • Try to search anything
      • Try to search something with video
    • Log into FB
      Update of the GBE
    • Other (from PR)

Checked PRs / bugfixes

New issues

@GRadziejewski
Copy link

Tests for iteration nr 1 are finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp-classen philipp-classen philipp-classen approved these changes

@chrmod chrmod Awaiting requested review from chrmod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smalluban @GRadziejewski @chrmod @philipp-classen