Update library dependencies #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
|
Since we still rely on old version, we will not update cluster-api-provider-vsphere dependencies here. See https://github.com/giantswarm/cluster-api-provider-vsphere-app/blob/main/Makefile.custom.mk#L8 Don't merge this PR. Keep it open to track the status. |
|
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting |
Bumps [sigs.k8s.io/cluster-api-provider-vsphere](https://github.com/kubernetes-sigs/cluster-api-provider-vsphere) from 1.6.0 to 1.8.0. - [Release notes](https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/releases) - [Commits](kubernetes-sigs/cluster-api-provider-vsphere@v1.6.0...v1.8.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/cluster-api-provider-vsphere dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
erkanerol
force-pushed
the
dependabot/go_modules/sigs.k8s.io/cluster-api-provider-vsphere-1.8.0
branch
from
a40779c
to
2b116ee
Compare
erkanerol
changed the title
erkanerol
force-pushed
the
dependabot/go_modules/sigs.k8s.io/cluster-api-provider-vsphere-1.8.0
branch
from
2b116ee
to
23d82f2
Compare
erkanerol
reviewed
Jul 24, 2024
| @@ -87,11 +88,12 @@ func mainE(ctx context.Context) error { | |||
| } | |||
|
|
|||
| mgr, err := ctrl.NewManager(config, ctrl.Options{ | |||
| Scheme: scheme, | |||
| MetricsBindAddress: metricsAddr, | |||
| Port: 9443, | |||
There was a problem hiding this comment.
This is the default value and we don't have webhook in this operator. Port is useless here.
erkanerol
deleted the
dependabot/go_modules/sigs.k8s.io/cluster-api-provider-vsphere-1.8.0
branch
This was referenced Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps sigs.k8s.io/cluster-api-provider-vsphere from 1.6.0 to 1.8.0.
Release notes
Sourced from sigs.k8s.io/cluster-api-provider-vsphere's releases.
... (truncated)
Commits
cf7352aMerge pull request #2201 from kubernetes-sigs/dependabot/go_modules/k8s.io/cl...079cf34Merge pull request #2185 from chrischdi/pr-clustermodule-doesexist-leak0a51d7cclustermodules: prevent creation of new modules if DoesExist returns an error5c73e2aMerge pull request #2196 from kubernetes-sigs/dependabot/github_actions/actio...dee965b🌱 Bump k8s.io/cluster-bootstrap from 0.27.2 to 0.27.4a88d186Merge pull request #2200 from kubernetes-sigs/dependabot/go_modules/k8s.io/ap...1385fc2🌱 Bump k8s.io/apiextensions-apiserver from 0.27.2 to 0.27.40283ea9Merge pull request #2197 from kubernetes-sigs/dependabot/go_modules/k8s.io/cl...d1947b3🌱 Bump k8s.io/client-go from 0.27.2 to 0.27.476ec8bb🌱 Bump actions/setup-go from 4.0.1 to 4.1.0You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)