Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

push to capa-capv addons #103

Merged
merged 1 commit into from
Aug 20, 2024
Merged

push to capa-capv addons #103

merged 1 commit into from
Aug 20, 2024

Conversation

anvddriesch
Copy link
Contributor

giantswarm/roadmap#3624

This PR:

  • adds/changes/removes etc

Testing

Description on how {APP-NAME} can be tested.

  • fresh install works
  • upgrade from previous version works

Other testing

Description of features to additionally test for {APP-NAME} installations.

  • check reconciliation of existing resources after upgrading
  • X still works after upgrade
  • Y is installed correctly

Checklist

  • Update changelog in CHANGELOG.md.
  • Make sure values.yaml and values.schema.json are valid.
  • Update lastpass values if required.

@anvddriesch anvddriesch self-assigned this Aug 19, 2024
@anvddriesch anvddriesch requested a review from a team as a code owner August 19, 2024 11:52
glitchcrab
glitchcrab approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@glitchcrab glitchcrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anvddriesch anvddriesch merged commit db0c75e into main Aug 20, 2024
3 checks passed
@anvddriesch anvddriesch deleted the capa-capv branch August 20, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glitchcrab glitchcrab glitchcrab approved these changes

Assignees

@anvddriesch anvddriesch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anvddriesch @glitchcrab