Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the gh action that detects the drift #71

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the gh action that detects the drift #71

wants to merge 1 commit into from

Conversation

jkremser
Copy link
Contributor

@jkremser jkremser requested a review from a team as a code owner July 26, 2023 12:22
glitchcrab
glitchcrab reviewed Jul 27, 2023
View reviewed changes
.github/workflows/check_generated.yaml
runs-on: ubuntu-latest
steps:
- name: checkout
uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # tag=v3.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for using the sha as opposed to the tag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy&pasta from my other repo where I have renovate doing this updates + commenting with the human readable format. I like the sha because it's more secure, tags can be rewritten with some malicious version that can do X.

Coming up with a harmful code that will have exactly this sha is much more harder (so basically paranoia is the reason I guess :D)

@jkremser jkremser requested review from a team and glitchcrab August 1, 2023 08:38
@vxav
Copy link
Contributor

vxav commented Sep 26, 2024

Do we still need this?

@erkanerol
Copy link
Contributor

@vxav I think so. My intention was always to rebase this change and test and merge but I couldn't find a change. SORRRYYYYY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glitchcrab glitchcrab Awaiting requested review from glitchcrab

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkremser @vxav @erkanerol @glitchcrab