Initial Flatcar support for CAPZ #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update reservation script to work both on ubuntu and flatcar * pre-create /var/lib/kubelet
primeroz
changed the title
…Community Gallery rather than the marketplace
primeroz
force-pushed
the
flatcar-testing
branch
from
472289a
to
1b9bc59
Compare
marians
reviewed
Mar 6, 2023
Also fix the Makefile to actually normalize the schema on the normalize target
primeroz
force-pushed
the
flatcar-testing
branch
from
6debdc9
to
b73efdf
Compare
bavarianbidi
approved these changes
Mar 7, 2023
marians
reviewed
Mar 7, 2023
marians
reviewed
Mar 7, 2023
marians
reviewed
Mar 7, 2023
marians
reviewed
Mar 7, 2023
| "type": "string" | ||
| }, | ||
| "name": { | ||
| "default": "{{ printf \"capi-flatcar-stable-%s-gen2\" .Values.internal.kubernetesVersion }}", |
There was a problem hiding this comment.
Suggested change
| "default": "{{ printf \"capi-flatcar-stable-%s-gen2\" .Values.internal.kubernetesVersion }}", | |
| "default": "capi-flatcar-stable-%s-gen2", |
There was a problem hiding this comment.
I know it is ugly, I can try something else 👍
There was a problem hiding this comment.
I don't think we can do it like that , because if we move the helm function out of the variable name we risk
capi-flatcar-stable-XXX-gen2%!(EXTRA string=1.24.11)
if a value without -%s is passed in
There was a problem hiding this comment.
best i can do is
- have an empty default
- if the value is empty then use an hardcoded template to render the name
- if the value is defined use the value as it is
There was a problem hiding this comment.
@marians please check updated code
Co-authored-by: Marian Steinbach <[email protected]>
Co-authored-by: Marian Steinbach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#1659